Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant question marks for channel update params #7333

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

donaldchen
Copy link
Contributor

@donaldchen donaldchen commented Jan 6, 2025

Because the JSON fields for the channel update payload are all optional, either all of the fields or none of the fields in the table should have the ? which indicates optionality. I chose to remove the ? for all of them, so developers can refer to this highlighted part of the doc as the source of truth.

Screenshot 2025-01-06 at 3 24 10 PM

@donaldchen donaldchen marked this pull request as ready for review January 6, 2025 23:25
@donaldchen donaldchen requested a review from a team as a code owner January 6, 2025 23:25
@donaldchen donaldchen requested review from shaydewael and removed request for a team January 6, 2025 23:25
@Misha-133
Copy link
Contributor

This PR also removes ? indicating nullable fields, not optional. It is a different thing and should not be changed. https://discord.com/developers/docs/reference#nullable-and-optional-resource-fields

@donaldchen
Copy link
Contributor Author

This PR also removes ? indicating nullable fields, not optional. It is a different thing and should not be changed. https://discord.com/developers/docs/reference#nullable-and-optional-resource-fields

Good catch! I'll update that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants