Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clarifications in permissions docs #7332

Merged

Conversation

donaldchen
Copy link
Contributor

@donaldchen donaldchen commented Jan 6, 2025

This PR adds the docs clarifications requested from #7318 .

A few notes:

  • CREATE_GUILD_EXPRESSIONS and CREATE_EVENTS permissions are still not public
  • I unabbreviated T, V, and S in a new table, but I didn't map them to every channel type because the mapping is different based on the permission. For example, T applies to GUILD_VOICE (for its associated text chat) for a permission like SEND_MESSAGES, but it doesn't apply to GUILD_VOICE for a permission like CREATE_PUBLIC_THREADS

@donaldchen donaldchen marked this pull request as ready for review January 6, 2025 22:33
@donaldchen donaldchen requested a review from a team as a code owner January 6, 2025 22:33
@donaldchen donaldchen requested review from JustinBeckwith and removed request for a team January 6, 2025 22:33
@advaith1
Copy link
Contributor

advaith1 commented Jan 6, 2025

For example, T applies to GUILD_VOICE (for its associated text chat) for a permission like SEND_MESSAGES

I think every permission that applies to text-in-voice has V for voice now?

@donaldchen
Copy link
Contributor Author

I think every permission that applies to text-in-voice has V for voice now?

Oh I see. In that case, I think I can make a mapping from T to channel types that is consistent for every permission then

docs/topics/Permissions.md Outdated Show resolved Hide resolved
Co-authored-by: advaith <advaithj1@gmail.com>
@shaydewael shaydewael merged commit 4000472 into discord:main Jan 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants