Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Safety Alerts Channel #2725

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Added Safety Alerts Channel #2725

merged 1 commit into from
Oct 5, 2024

Conversation

RealYusufIsmail
Copy link
Contributor

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

Added getSafetyAlertsChannel allowing you to get the channel to which Discord sends alerts to.

@RealYusufIsmail RealYusufIsmail force-pushed the safety_alerts_channel_id branch 2 times, most recently from 1619786 to 7451e48 Compare August 28, 2024 21:27
freya022
freya022 suggested changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@freya022 freya022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need the put the fully qualified name in the javadocs if the type is already imported

@RealYusufIsmail RealYusufIsmail force-pushed the safety_alerts_channel_id branch from 7451e48 to 733f71f Compare August 28, 2024 21:33
freya022
freya022 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@freya022 freya022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, I haven't compared to similar classes though

DV8FromTheWorld
DV8FromTheWorld approved these changes Oct 5, 2024
View reviewed changes
Copy link
Member

@DV8FromTheWorld DV8FromTheWorld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DV8FromTheWorld DV8FromTheWorld merged commit 5644b5e into discord-jda:master Oct 5, 2024
1 check passed
@RealYusufIsmail RealYusufIsmail deleted the safety_alerts_channel_id branch October 8, 2024 13:39
@renovate renovate bot mentioned this pull request Dec 9, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DV8FromTheWorld DV8FromTheWorld DV8FromTheWorld approved these changes

@freya022 freya022 freya022 approved these changes

Assignees
No one assigned
Labels
type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RealYusufIsmail @DV8FromTheWorld @freya022 @MinnDevelopment