Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Angular v15 and MDC-based MatTable #112

Closed
wants to merge 5 commits into from

Conversation

TobiDimmel
Copy link

This updates to Angular v15 and its new MDC-based MatTable. The old and now MatLegacyTable called table version is not supported with this PR.

Unless MatLegacyTable is supported via another PR this should be considered a breaking change because the default update process via Angular CLI migrates usages of MatTable (v14) to MatLegacyTable (v15) automatically for users (seen in 1b77c96). Users would need to migrate to MatTable (v15) via migration script to use this library without any issues.

The update was done via Angular CLI and the migration script of @angular/material. Since the CSS classes have a different prefix in the MDC-based version, the classes for sticky header and footer were updated.

Fixes #111

@TobiDimmel
Copy link
Author

@diprokon Let me know if something needs to change. I'm happy to help.

On my machine the tests npm run test-ci aren't working at all.
Is this a general problem or a problem on my end?

@diprokon
Copy link
Owner

Hi @TobiDimmel!
Thanks for contributing, but I will have to close this PR
I'm already working on this and the next update should fix the ng15 issues, tests issues and few more

@diprokon diprokon closed this Jan 13, 2023
@TobiDimmel
Copy link
Author

OK. I'm looking forward to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular/Material 15, sticky header does not work
2 participants