Release 1.2.13

digitoimistodude · Dec 17, 2024 · ba465df · ba465df
1 parent f1f0b91
commit ba465df
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+### 1.2.13: 2024-12-17
+
+* Fix rendering function breaking if field was changed from multiple to single
+
 ### 1.2.12: 2024-12-16
 
 * Properly setup field data when rendering

diff --git a/acf-field-network-post-select.php b/acf-field-network-post-select.php
@@ -3,7 +3,7 @@
  * Plugin Name: Advanced Custom Fields: Network posts select field
  * Plugin URI: https://github.com/digitoimistodude/acf-field-network-post-select
  * Description: Adds a ACF field that allows selecting posts across the network sites.
- * Version: 1.2.12
+ * Version: 1.2.13
  * Author: Digitoimisto Dude Oy
  * Author URI: https://www.dude.fi
  * License: GPLv3 or later
@@ -21,7 +21,7 @@ class sippis_acf_plugin_network_post_select { // phpcs:ignore PEAR.NamingConvent
 
   function __construct() { // phpcs:ignore PSR2.Classes.PropertyDeclaration.ScopeMissing, Squiz.Scope.MethodScope.Missing
 		$this->settings = array(
-		'version'  => '1.2.12',
+		'version'  => '1.2.13',
 		'url'      => plugin_dir_url( __FILE__ ),
 		'path'     => plugin_dir_path( __FILE__ ),
 		);

diff --git a/class-sippis-acf-field-network-post-select.php b/class-sippis-acf-field-network-post-select.php
@@ -380,7 +380,7 @@ function render_field( $field ) { // phpcs:ignore
 
     if ( isset( $field['multiple'] ) && 1 === $field['multiple'] ) {
       // If we have previous single value, reset
-      if ( isset($field['value']['site_id'] ) ){
+      if ( isset($field['value']['site_id'] ) ) {
         $field['value'] = [];
       }
 
@@ -394,15 +394,15 @@ function render_field( $field ) { // phpcs:ignore
       $field['value'] = $new_vals;
     } else {
       // If we have previous multiple, reset
-      if ( ! isset($field['value']['site_id'] ) ){
+      if ( ! isset($field['value']['site_id'] ) ) {
         $field['value'] = [];
+      } else {
+        // try to get posts based on field value
+        $posts = $this->get_posts( $field['value'], $field );
+
+        // change field value format so it's in same format with AJAX query return
+        $field['value'] = $field['value']['site_id'] . '|' . $field['value']['post_id'];
       }
-
-      // try to get posts based on field value
-      $posts = $this->get_posts( $field['value'], $field );
-
-      // change field value format so it's in same format with AJAX query return
-      $field['value'] = $field['value']['site_id'] . '|' . $field['value']['post_id'];
     }
 
     if ( $posts ) {

diff --git a/composer.json b/composer.json
@@ -8,5 +8,5 @@
     "plugin"
   ],
   "license": "GPLv3",
-  "version": "1.2.12"
+  "version": "1.2.13"
 }