README: fix jsonpath for pod name #19
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
reviewed
May 12, 2023
| @@ -29,7 +29,7 @@ If you know the specific node name that you're interested in, you can exec into | |||
|
|
|||
| ```bash | |||
| NODE_NAME="my-node-name" | |||
| POD_NAME=$(kubectl -n kube-system get pods --field-selector spec.nodeName=${NODE_NAME} -ojsonpath='{.items[0].metadata.name}') | |||
| POD_NAME=$(kubectl -n kube-system get pods --field-selector spec.nodeName=${NODE_NAME} -ojsonpath='{.items[?(@.metadata.labels.name=="doks-debug")].metadata.name}') | |||
There was a problem hiding this comment.
I think a better approach is to use the label that should uniquely identify doks-debug.
Personally, I generally prefer using custom columns over dealing with JSON whenever I can, so this is how I'd go about it:
POD_NAME=$(kubectl get pod -l name=doks-debug --field-selector spec.nodeName=${NODE_NAME} --no-headers -o custom-columns=:.metadata.name)There was a problem hiding this comment.
@dhij could you check in on that? Take care to add -n kube-system still if you use Timo's command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-ojsonpath='{.items[0].metadata.name}'gave me a pod name for cilium so I was thinking we could use this approach or sort by.metadata.creationTimestampbefore choosingitems[0]