Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor API key handling #374

Merged
merged 4 commits into from
Aug 1, 2022
Merged

Refactor API key handling #374

merged 4 commits into from
Aug 1, 2022

Conversation

timobrembeck
Copy link
Member

Short description

This adds various improvements for the API key handling

Proposed changes

Resolved issues

Fixes: #269
Fixes: #271
Fixes: #285

@timobrembeck timobrembeck requested a review from a team as a code owner July 25, 2022 17:50
Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really cool PR!
Thank you a lot for the new features and then fixes :)
I didn't run into any issues during my test run :)

- Add setting DEFAULT_AUTO_FIELD
- Use automatically generated id fields
@timobrembeck timobrembeck force-pushed the refactoring/api-keys branch from 9a10c49 to 22c4478 Compare August 1, 2022 08:19
- Add django-qr-code as dependency
- Add urls for dynamic QR code generation
- Generate QR codes for API keys
@timobrembeck timobrembeck merged commit 3df0e4c into develop Aug 1, 2022
@timobrembeck timobrembeck deleted the refactoring/api-keys branch August 1, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10-digit-key should match the requirements QR-Code Generator Custom API-Key
2 participants