Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cli.py #304

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Update cli.py #304

merged 2 commits into from
Dec 5, 2024

Conversation

eveleighoj
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

importing spatialite can cause errors when using subproccess to run additional processes. We may. want to move away from it completely but for now only importing in for the valid command will improve it.

Related Tickets & Documents

  • Ticket Link
  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: tests already in place but need to make sure none fail
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] Are there any dependencies on other PRs or Work?

@eveleighoj eveleighoj merged commit c2a1524 into main Dec 5, 2024
3 checks passed
@eveleighoj eveleighoj deleted the fix/spatialite-bug branch December 5, 2024 10:35
cjohns-scottlogic pushed a commit that referenced this pull request Dec 9, 2024
* Update cli.py

* run  black
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant