Convert phase: Adds saving converted input as a csv #149
Conversation
Removes old method of saving converted .csv to disk
tests/unit/test_convert.py
Outdated
| @@ -13,3 +13,55 @@ def test_load_xlsm(): | |||
| assert block["line-number"] == 1 | |||
| assert "OrganisationURI" in block["line"] | |||
| assert log.mime_type == "application/vnd.ms-excel" | |||
|
|
|||
There was a problem hiding this comment.
So it's not your fault that this test doesn't exist but we need a test that checks what happens when a custom_temp_dir is not used. I.e. if the user of the function does not want to to store the data in a directory they can find later then what happens.
Your current code would still create the files in the converted folder.
There was a problem hiding this comment.
Another test to write would be one that could test for data not being in the converted folder and instead being in a user data
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
=======================================
Coverage 79.43% 79.44%
=======================================
Files 67 67
Lines 3594 3600 +6
=======================================
+ Hits 2855 2860 +5
- Misses 739 740 +1
☔ View full report in Codecov by Sentry. |
Compares all files before + after to look for difference
This PR adds functionality to the convert phase so that when the input file (geojson, xlsm etc) is converted to a .csv file, this is saved to disk (rather than a temporary file). The location of where the file is saved is determined by arguments for the ConvertPhase class. If these arguments aren't present then the file isn't saved to disk.
This is required so the pipeline-runner can use the converted input .csv as part of its response.