-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fatal Error Call #33
Comments
Thanks for reporting this @djmaxw3ll 🙂 What is the size of the collection you're trying to convert, how many tracks? Thanks |
Hi Alex, roughly 25,000
Regards
Peter Maxwell
07399 829573
0fad0940@opayq.com
From: Alex Coyle (ALZA) <>
Sent: 27 July 2020 21:49
To: 0fad0940@opayq.com<mailto:0fad0940@opayq.com>
Cc: djmaxw3ll<mailto:0fad0940@opayq.com>; Mention<mailto:mention@noreply.github.com>
Subject: Re: [digital-dj-tools/dj-data-converter] Fatal Error Call (#33)
Preview: Thanks for reporting this @djmaxw3ll 🙂 What is the size of t --> SPAM? CLICK to BLOCK<https://dnt.abine.com/#/block_email/0fad0940@opayq.com/>
This email is Masked using Blur - it was sent from github.com to 0fad0940@opayq.com (your reply stays Masked). To protect your privacy<https://www.abine.com/faq.html#caniaddcc>, do not forward this message, or add new recipients like CCs or BCCs.
Thanks for being a Blur customer! If you haven't yet, [ Try DeleteMe at a discount.<https://joindeleteme.com/?utm_source=blur&utm_medium=email&utm_campaign=blur-offer> ]
Thanks for reporting this @djmaxw3ll<https://github.com/djmaxw3ll> 🙂
What is the size of the collection you're trying to convert, how many tracks?
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#33 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEWDCM7S3UYYMJXFHVZURCLR5XR4BANCNFSM4PDGUAQA>.
|
Investigation to determine if GraalVM can be used to fix #33. So that Clojure/Java impl of data.xml is used instead of ClojureScript. Using Clojure 1.10.2-alpha1 and spec-tools 0.10.0 Using xfthhxk fix for luchiniatwork/cambada#9 Working for files that don't exist (Traktor to Rekordbox) Error for files that exist, from mp3-parser (Traktor to Rekordbox) Error for all files? (Rekordbox to Traktor)
Investigation to determine if GraalVM can be used to fix #33. Now working for files that exist (Traktor to Rekordbox) Fixed error from mp3-parser
Investigation to determine if GraalVM can be used to fix #33. Now working for files that exist (Traktor to Rekordbox) Fixed error from mp3-parser
Investigation to determine if GraalVM can be used to fix #33. Now working for all files (Rekordbox to Traktor)
Investigation to determine if GraalVM can be used to fix #33. Now working for all files (Rekordbox to Traktor)
Investigation to determine if GraalVM can be used to fix #33. Now working for all files (Rekordbox to Traktor)
Hi @djmaxw3ll, Some good news, I've now got a working build that should allow larger collections to be processed more efficiently without running out of memory 🙂 Here's a very informal performance comparison between the existing NodeJS build and the new experimental GraalVM build...
Looks promising, although this is just execution time of course and not memory usage. However, I'm hoping that memory usage will be lower on GraalVM, because the Clojure/Java implementation of data.xml parsing is much more efficient than the ClojureScript/NodeJS implementation, and will therefore allow larger files to be processed without running out of memory. The next step is to modify the Azure Devops build to produce Windows and/or Mac GraalVM images for testing. Regarding Windows and/or Mac, from the screenshot above it looks like you're on Windows, is that correct @djmaxw3ll? Thanks! |
Hi @djmaxw3ll, I've got a Windows build for you to test with, see attached... Please can you download, run it on your Traktor collection and let me know the result? Thanks! 🙂 |
The text was updated successfully, but these errors were encountered: