Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datepicker does not remove event listeners properly #247

Closed
jsebrech opened this issue Aug 6, 2021 · 0 comments · Fixed by #251
Closed

Datepicker does not remove event listeners properly #247

jsebrech opened this issue Aug 6, 2021 · 0 comments · Fixed by #251
Assignees
@jsebrech
Labels
bug Something isn't working

Comments

@jsebrech
Copy link
Contributor

jsebrech commented Aug 6, 2021 •
edited
Loading

Describe the bug

The Datepicker component adds event listeners in componentDidMount but removes them in componentDidUpdate instead of componentDidUnmount. This is incorrect and in some cases causes the error "Error: Unable to find node on an unmounted component"

Expected behavior

Datepicker should removed event listeners in componentWillUnmount instead of componentDidUpdate.

Additional context

This issue came up in project "Regie Kinderopvang" by Aptus.
@jsebrech jsebrech added the bug Something isn't working label Aug 6, 2021
@jsebrech jsebrech self-assigned this Aug 6, 2021
jsebrech added a commit that referenced this issue Aug 13, 2021
@jsebrech
properly remove datepicker event listeners
1f77d42 
fixes #247
@jsebrech jsebrech mentioned this issue Aug 13, 2021
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsebrech jsebrech

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/checkbox and datepicker digipolisantwerp/antwerp-ui_react
1 participant
@jsebrech