Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reformat docs for diffraction objects #251

Closed
wants to merge 1 commit into from

Conversation

yucongalicechen
Copy link
Contributor

@sbillinge this PR is a reformat of #249. When I just rendered the doc I saw some codes were not shown / formatted poorly because I had some codes wrong. Now it's corrected. ready for merge.

Copy link

Warning! No news item is found for this PR. If this is a user-facing change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (641a107) to head (baef1e4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #251   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          380       380           
=========================================
  Hits           380       380           

@sbillinge
Copy link
Contributor

@yucongalicechen I saw that. I merged because it is easier to edit docs not on branches. I did the fix and some rewriting. We probably want to close this PR. Please make sure that there is not anything you want from here then we can close.

@yucongalicechen
Copy link
Contributor Author

closed as replaced by #254

@yucongalicechen yucongalicechen deleted the do-docs2 branch December 19, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants