DiffractionObject can now be instantiated directly #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cture is a 2D array with everything in it
bobleesj
reviewed
Dec 4, 2024
| xarray = np.empty(0) | ||
| if yarray is None: | ||
| yarray = np.empty(0) | ||
| self.insert_scattering_quantity( |
There was a problem hiding this comment.
nice re-use of insert_scattering_quantity
bobleesj
reviewed
Dec 4, 2024
| self.name = name | ||
| self.wavelength = wavelength | ||
| self.all_arrays = np.empty(shape=(len(yarray), 4)) | ||
| self.all_arrays[:, 0] = yarray |
There was a problem hiding this comment.
This is much much easier to read now!
bobleesj
reviewed
Dec 4, 2024
| "scat_quantity": "x-ray", | ||
| "wavelength": 0.71, | ||
| "xtype": "q", | ||
| "xarray": np.array([1.0, 2.0]), |
|
@sbillinge Also passes locally now. Just checked out your branch. |
|
thank for the review @bobleesj . I will merge this now so the team can push on..... |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
==========================================
- Coverage 97.31% 96.53% -0.78%
==========================================
Files 8 8
Lines 261 289 +28
==========================================
+ Hits 254 279 +25
- Misses 7 10 +3
|
This was referenced Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #185
closes #181
closes #177
and basic data structure is a 2D array with everything in it