Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scattering_objects folder for importing DiffractionObjects #189

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

bobleesj
Copy link
Contributor

@bobleesj bobleesj commented Dec 2, 2024

Closes #182

@bobleesj bobleesj marked this pull request as ready for review December 2, 2024 20:35
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.31%. Comparing base (49bb353) to head (16937e7).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   97.31%   97.31%           
=======================================
  Files           8        8           
  Lines         261      261           
=======================================
  Hits          254      254           
  Misses          7        7           
Files with missing lines Coverage Δ
tests/diffpy/utils/test_diffraction_objects.py 84.61% <100.00%> (ø)

@bobleesj
Copy link
Contributor Author

bobleesj commented Dec 2, 2024

@sbillinge ready for review

from

from diffpy.utils.scattering_objects.diffraction_objects import DiffractionObject

to

from diffpy.utils.diffraction_objects import DiffractionObject, PdfObject

@sbillinge
Copy link
Contributor

Nicely done, @bobleesj thanks!

@sbillinge sbillinge merged commit 61412cd into diffpy:main Dec 3, 2024
5 checks passed
@bobleesj bobleesj deleted the remove-scattering branch December 3, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove scattering_object layer
2 participants