-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve dependencies per-project #983
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll the root-project synchronization problems we were having. I'm keeping the hooks we would need to go back to centralized dep resolution in the future in case we decide to go back to that for some reason.
This was referenced Nov 7, 2021
…nt in the same project.
…ssage for failures.
…is to check to see if transient fields are null.
…itRatchetGradle be a POJO field of the service. Doesn't matter either way for now, but this sets us up for a refactor in the future.
…doesn't do anything and if it ever does do something it will be surpising if it's just some tasks.
Released in plugin-gradle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That leads to a lot of duplication, but there is a clear path to recentralize from here if we want to get that performance back. After this PR, spotless can build and run without any warnings from configuration cache. However, it doesn't actually work, and many things will break if you try to do it, although it's surprising how many things do work.
But if you aren't using configuration-cache and you just have a giant multi-module project which has been barfing on our root-project synchronization, this PR is the ultimate fix to #941.