Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve dependencies per-project #983

Merged
merged 14 commits into from
Nov 9, 2021
Merged

Conversation

nedtwigg
Copy link
Member

@nedtwigg nedtwigg commented Nov 7, 2021

That leads to a lot of duplication, but there is a clear path to recentralize from here if we want to get that performance back. After this PR, spotless can build and run without any warnings from configuration cache. However, it doesn't actually work, and many things will break if you try to do it, although it's surprising how many things do work.

But if you aren't using configuration-cache and you just have a giant multi-module project which has been barfing on our root-project synchronization, this PR is the ultimate fix to #941.

…ll the root-project synchronization problems we were having. I'm keeping the hooks we would need to go back to centralized dep resolution in the future in case we decide to go back to that for some reason.
@nedtwigg nedtwigg changed the title Resolve dependencies per-project (configuration-cache works-ish) (3 of 3) Resolve dependencies per-project Nov 9, 2021
Base automatically changed from feat/spotless-task-service to main November 9, 2021 05:59
@nedtwigg nedtwigg merged commit 24d1ea5 into main Nov 9, 2021
@nedtwigg nedtwigg deleted the feat/dep-resolve-per-project branch November 9, 2021 06:14
@nedtwigg
Copy link
Member Author

nedtwigg commented Nov 9, 2021

Released in plugin-gradle 6.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant