Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazily check for foreign exes which may not be necessary for the curr… #1257

Merged
merged 6 commits into from
Jul 27, 2022
Merged

Lazily check for foreign exes which may not be necessary for the curr… #1257

merged 6 commits into from
Jul 27, 2022

Conversation

bh-tt
Copy link
Contributor

@bh-tt bh-tt commented Jul 11, 2022 •
edited
Loading

Run ForeignExe#confirmVersionAndGetAbsolutePath only once it is necessary.

Discussed in #673, I decided to make the 2 State implementations lazy with resolving the arguments.

nedtwigg
nedtwigg requested changes Jul 12, 2022
View reviewed changes
Copy link
Member

@nedtwigg nedtwigg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, thanks! Needs some minor tweaks, but I like the approach.

Also, run spotlessApply so that CI passes :)

CHANGES.md Outdated Show resolved Hide resolved
lib/src/main/java/com/diffplug/spotless/cpp/ClangFormatStep.java Outdated Show resolved Hide resolved
lib/src/main/java/com/diffplug/spotless/cpp/ClangFormatStep.java Outdated Show resolved Hide resolved
lib/src/main/java/com/diffplug/spotless/python/BlackStep.java Outdated Show resolved Hide resolved
lib/src/main/java/com/diffplug/spotless/python/BlackStep.java Outdated Show resolved Hide resolved
@bh-tt
Copy link
Contributor Author

bh-tt commented Jul 13, 2022

I processed your comments. Running ./gradlew spotlessApply from the project root changed no files, I'll assume that means the format is fine?

@bh-tt
Copy link
Contributor Author

bh-tt commented Jul 13, 2022

Not even ./gradlew :lib:spotlessApply changes any files. I'm developing in a minimal container (only java, gradle and git installed), could that have something to do with it?

@nedtwigg
Copy link
Member

Sorry for the slow merge. I'll get this released by tomorrow. The spotlessApply issue you were bumping into is #1238

@nedtwigg nedtwigg enabled auto-merge July 26, 2022 23:20
@nedtwigg nedtwigg merged commit d78b6e3 into diffplug:main Jul 27, 2022
@nedtwigg
Copy link
Member

Sorry for the slow turnaround - finally released in plugin-gradle 6.9.0 and plugin-maven 2.24.0.

@bh-tt bh-tt mentioned this pull request Aug 1, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedtwigg nedtwigg nedtwigg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bh-tt @nedtwigg