Allow metadata setting for a document #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks man! I'm going to write some tests for this if you are ok and then merge it. |
diegomura
reviewed
Oct 23, 2017
| } | ||
| if (keywords) { | ||
| this.root.info.Keywords = keywords; | ||
| } |
There was a problem hiding this comment.
Are these 4 the only type of metadata possible? (I don't actually know 😅 )
Also. is there a problem if some metadata keeps set asnull value? I'm asking if we can get rid of the ifs statements, or maybe replacing them for title || undefined. Maybe I'm being a bit nitpicking here haha sorry
There was a problem hiding this comment.
Don't worry. I answer myself 😅 . Didn't worked with the way I suggested
|
I added some comments 😄 |
|
@rogierslag I added some other changes. Hope you don't mind 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow one to set the pdf metadata again. See the example how to.