Fix/d100 is 0 gy #74
Merged
Fix/d100 is 0 gy #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting this. I will review shortly and I think it looks good to merge so far. |
Closed
|
I checked it out and it looks great! Just merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dose_constraint(100) now give the expected value, and not 0 Gy. I also added a test that assure this.
The method always returned 0 because of that:
np.argminnote:SOLUTION:
flip the array and apply np.argmin to get the minimum value index of the reversed array.
After, substract the biggest possible index of the array by the minimum value index to get the real index where the D100 value is.
related to #25