MenuEdit: Add undo/redo options for frame ops #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9012ef to
61c9fe5
Compare
61b5b5b to
df946b4
Compare
df946b4 to
38dbcf4
Compare
Introduces FrameCmds source file/header file which will be used for undo/redo operations for all operations used in frames.
38dbcf4 to
fc3cd3b
Compare
StephenCWills
requested changes
Nov 19, 2023
bd09dfe to
f87d02d
Compare
This commit makes "delete frame" option to be undoable, it allows to delete frame and then undo or redo the same action.
This commit makes insert/add options to be undoable, it allows to insert/add a frame and then undo or redo the same action.
This commit makes "replace frame" option to be undoable, it allows to replace frame and then undo or redo the same action.
f87d02d to
1cbc1dc
Compare
StephenCWills
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds undo stack for frame options in "Edit" menu in the app. Currently, if we try to remove frame/insert/append/replace frame, it's possible, although we can't revert the result that we've acquired. This patch adds this possibility for the following options:
While this patch might work by itself, there may be some dependencies with different operations in the app, like adding tiles or megatiles. Those will be supported in undo stack in the next PRs that will come.