Handle start time & repeats #7
Conversation
artursouza
commented
Mar 16, 2024
•
- Support startTime for delayed start of the cron (1h from now, for example)
- Support for repeats (trigger 3 times only, for example)
- Support custom logic to stop (delete) job, so app can stop the job with any logic they want
- Removed unused struct
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
| assert.True(t, updated) | ||
| assert.Equal(t, 3, value) | ||
|
|
||
| time.Sleep(time.Second) |
There was a problem hiding this comment.
Please, use the k8s Clock so that it can be mocked in tests and can execute immediately. https://github.com/dapr/dapr/blob/ed56f692122d0afef7c79147f77eb283acb10467/pkg/placement/placement.go#L154
There was a problem hiding this comment.
Can't do it because the expiration is handled by etcd, so we need to wait for a real expiration in the database.
| map<string, string> metadata = 3; | ||
| google.protobuf.Any payload = 4; | ||
| int64 startTimestamp = 3; // time that the schedule starts | ||
| int32 repeats = 4; // time total time the job should trigger |
There was a problem hiding this comment.
Any reason not to use 32? it is odd to not be consistent.
| int32 repeats = 4; // time total time the job should trigger | |
| int64 repeats = 4; // time total time the job should trigger |
There was a problem hiding this comment.
int64 is a requirement for time. While the repeats is not expected to be that large, making int64 overkill. Even int32 is already "too much".
Co-authored-by: Josh van Leeuwen <me@joshvanl.dev> Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Co-authored-by: Josh van Leeuwen <me@joshvanl.dev> Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
We are not using second-tick, second is just the granularity chosen to keep the jobs. We will use priority queue to optimize the ticker since it is more efficient than re-sorting on every iteration. |
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Josh is not available due to an event. All applicable comments were addressed. Got another approval.