Leadership: re-reconcile on failed key read #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the event of failed reading of other leadership keys, the leader will continue to wait for the next informer reconcile instead of hard erroring out. This is useful for events whereby the leadership key space values are not readable because they have been written by another cron who has a different value API. Signed-off-by: joshvanl <me@joshvanl.dev>
cicoyle
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event of failed reading of other leadership keys, the leader will continue to wait for the next informer reconcile instead of hard erroring out.
This is useful for events whereby the leadership key space values are not readable because they have been written by another cron who has a different value API.