Refactor + some fixes and testing #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
cicoyle
reviewed
Mar 13, 2024
cicoyle
reviewed
Mar 13, 2024
| This fork has different goals from Scalingo's go-etcd-cron library. |
There was a problem hiding this comment.
Might be worth adding more details here, like what our diff goals are.
There was a problem hiding this comment.
They are on the top.
cicoyle
reviewed
Mar 13, 2024
| @@ -122,13 +106,13 @@ func WithErrorsHandler(f func(context.Context, Job, error)) CronOpt { | |||
| }) | |||
| } | |||
|
|
|||
| func WithEtcdMutexBuilder(b EtcdMutexBuilder) CronOpt { | |||
| func WithEtcdClient(c *etcdclient.Client) CronOpt { | |||
There was a problem hiding this comment.
Im now relying on this func: WithEtcdMutexBuilder in scheduler code:
c, err := etcdcron.NewEtcdMutexBuilder(clientv3.Config{Endpoints: etcdEndpoints})
Once we switch to this library in scheduler code we will need to keep this change in mind.
There was a problem hiding this comment.
Yes, this is cleaner IMO. Compilation errors are the best way to remember to change :)
cicoyle
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.