PHP 8.4

.github/workflows/build.yml

@@ -13,14 +13,14 @@ jobs:
       fail-fast: false
       matrix:
         operating-system: [ubuntu-latest]
-        php-versions: ["8.0", "8.1", "8.2", "8.3"]
+        php-versions: ["8.0", "8.1", "8.2", "8.3", "8.4"]
         composer-args: ["", "--prefer-lowest"]
     runs-on: ${{ matrix.operating-system }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
       - name: Setup PHP
-        uses: shivammathur/setup-php@2.31.1
+        uses: shivammathur/setup-php@2.32.0
         with:
           php-version: ${{ matrix.php-versions }}
           extensions: mbstring
@@ -49,7 +49,7 @@ jobs:
       - name: Test
         run: composer test-with-coverage
       - name: Upload Coverage
-        uses: codecov/codecov-action@v3
+        uses: codecov/codecov-action@v5
         with:
           files: ./clover.xml
           verbose: true

composer.json

@@ -10,7 +10,7 @@
     "license": "BSD-3-Clause",
     "prefer-stable": true,
     "require": {
-        "php": "~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0",
+        "php": "~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
         "diablomedia/zendframework1-exception": "^1.1.1",
         "diablomedia/zendframework1-xml": "^1.0.5",
         "diablomedia/zendframework1-server": "^1.0.5"
@@ -30,8 +30,8 @@
     },
     "require-dev": {
         "phpunit/phpunit": "^9.6.19 || ^10.5.18",
-        "phpstan/phpstan": "1.12.7",
-        "friendsofphp/php-cs-fixer": "3.55.0",
+        "phpstan/phpstan": "2.1.1",
+        "friendsofphp/php-cs-fixer": "3.67.0",
         "maglnet/composer-require-checker": "^3.0.0",
         "phpro/grumphp-shim": "^2.0.0"
     },

grumphp.yml.dist

@@ -1,5 +1,8 @@
 # grumphp.yml
 grumphp:
+    environment:
+        variables:
+            PHP_CS_FIXER_IGNORE_ENV: "true"
     tasks:
         composer:
             strict: true

phpstan.neon

@@ -1,5 +1,6 @@
 parameters:
     level: 4
+    treatPhpDocTypesAsCertain: false
     paths:
         - ./
     excludePaths:
@@ -8,11 +9,8 @@ parameters:
     ignoreErrors:
         # Method will exit if $method isn't defined (via a $found boolean in a loop)
         - '#Variable \$method might not be defined\.#'
-        # I think most of these null checks are unnecessary, but the return types may need null added if the property is never initialized
-        - '#Strict comparison using === between null and Zend_Json_Server_Request will always evaluate to false\.#'
-        - '#Strict comparison using === between null and Zend_Json_Server_Response will always evaluate to false\.#'
-        - '#Strict comparison using === between null and string will always evaluate to false\.#'
-        # Defensive coding where these can't be enforced by php type-hints
         -
-            message: '#Result of && is always false\.#'
-            path: %currentWorkingDirectory%/src/Zend/Json/Server.php
+            message: '#^Parameter &\$value by\-ref type of method Zend_Json\:\:_recursiveJsonExprFinder\(\) expects iterable\|Zend_Json_Expr, string given\.$#'
+            identifier: parameterByRef.type
+            count: 1
+            path: src/Zend/Json.php

src/Zend/Json/Decoder.php

@@ -332,7 +332,7 @@ protected function _getNextToken()
             case ':':
                 $this->_token = self::COLON;
                 break;
-            case  '"':
+            case '"':
                 $result = '';
                 do {
                     $i++;