bumping travis php versions, composer deps, fixing phpstan errors #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydiablo
commented
Feb 15, 2019
| @@ -160,8 +160,6 @@ public function setConfig(Zend_Config $config) | |||
| * Get optional decorator | |||
| * | |||
| * By default, return null, indicating no extra decorator needed. | |||
| * | |||
| * @return null | |||
There was a problem hiding this comment.
This is so it inherits the interface's docblock for the @return (above).
| @@ -357,7 +356,7 @@ public function generate() | |||
|
|
|||
| protected function _generateRandomId() | |||
| { | |||
| return md5(Zend_Crypt_Math::randBytes(32)); | |||
| return md5((string) Zend_Crypt_Math::randBytes(32)); | |||
There was a problem hiding this comment.
apparently the randBytes method can return false, this shouldn't change behavior though.
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
============================================
- Coverage 84.84% 84.68% -0.17%
- Complexity 204 206 +2
============================================
Files 10 10
Lines 561 568 +7
============================================
+ Hits 476 481 +5
- Misses 85 87 +2
Continue to review full report at Codecov.
|
diablodrew
approved these changes
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.