Add fatal error on missing EnvironmentVariable

dhardiman · Jan 22, 2024 · 47b0a31 · 47b0a31
1 parent 028f52a
commit 47b0a31
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/Sources/Config/Property.swift b/Sources/Config/Property.swift
@@ -157,7 +157,7 @@ enum PropertyType: String {
             guard let environmentVariable = value as? String,
                   let rawValue = getenv(environmentVariable),
                   let stringValue = String(utf8String: rawValue) else {
-                return "\"\""
+                fatalError("Missing environment variable \(value)")
             }
             return "#\"\(stringValue)\"#"
         default:

diff --git a/Tests/ConfigTests/ConfigurationPropertyTests.swift b/Tests/ConfigTests/ConfigurationPropertyTests.swift
@@ -356,13 +356,6 @@ class ConfigurationPropertyTests: XCTestCase {
         expect(actualValue).to(equal(expectedValue))
     }
 
-    func testItWritesAnEmptyStringForAnEnvironmentVariableThatIsNotSet() throws {
-        let property = ConfigurationProperty<String>(key: "test", typeHint: "EnvironmentVariable", dict: ["defaultValue": "DOESNT_EXIST"])
-        let expectedValue = ##"    static let test: String = """##
-        let actualValue = try whenTheDeclarationIsWritten(for: property)
-        expect(actualValue).to(equal(expectedValue))
-    }
-
     func testItCanUseCommonPatternsForOverrides() throws {
         let dict: [String: Any] = [
             "defaultValue": "test value",