Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: race in close #384

Merged
merged 3 commits into from
Jul 23, 2024
Merged

fix: race in close #384

merged 3 commits into from
Jul 23, 2024

Conversation

StarpTech
Copy link
Contributor

Related: #294

Fixes: #377

@CLAassistant
Copy link

CLAassistant commented Jul 15, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@StarpTech StarpTech marked this pull request as ready for review July 15, 2024 08:11
@StarpTech StarpTech requested a review from a team as a code owner July 15, 2024 08:11
@mangalaman93
Copy link
Contributor

Hi @StarpTech, Thanks for the PR. Apologies for the delay. Would it be possible for you to explain/use the sync/atomic package instead?

@StarpTech
Copy link
Contributor Author

@mangalaman93 no opinion on it. I copied the code from the previous contribution. I can also use the std library.

@mangalaman93
Copy link
Contributor

Yes, please. Std Library is perfect.

@StarpTech
Copy link
Contributor Author

StarpTech commented Jul 19, 2024 •
edited
Loading

I already used it but I did not tidy. Please recheck.

@mangalaman93 mangalaman93 merged commit f599748 into dgraph-io:main Jul 23, 2024
5 checks passed
@flymedllva flymedllva mentioned this pull request Dec 25, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mangalaman93 mangalaman93 mangalaman93 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing commits/PRs on main
3 participants
@StarpTech @CLAassistant @mangalaman93