convert bidders: gamoshi

dgirardi · May 20, 2022 · 6aeecac · 6aeecac
1 parent 8b66ebb
commit 6aeecac
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 21 deletions.
diff --git a/modules/fluctBidAdapter.js b/modules/fluctBidAdapter.js
@@ -39,7 +39,8 @@ export const spec = {
    */
   buildRequests: (validBidRequests, bidderRequest) => {
     const serverRequests = [];
-    const referer = bidderRequest.refererInfo.referer;
+    // TODO: is 'page' the right value here?
+    const referer = bidderRequest.refererInfo.page;
 
     _each(validBidRequests, (request) => {
       const data = Object();

diff --git a/modules/freewheel-sspBidAdapter.js b/modules/freewheel-sspBidAdapter.js
@@ -326,8 +326,8 @@ export const spec = {
           }
         }
       }
-
-      var location = (bidderRequest && bidderRequest.refererInfo) ? bidderRequest.refererInfo.referer : getTopMostWindow().location.href;
+      // TODO: is 'page' the right value here?
+      var location = bidderRequest?.refererInfo?.page;
       if (isValidUrl(location)) {
         requestParams.loc = location;
       }

diff --git a/modules/gammaBidAdapter.js b/modules/gammaBidAdapter.js
@@ -27,7 +27,7 @@ export const spec = {
    */
   buildRequests: function(bidRequests, bidderRequest) {
     const serverRequests = [];
-    const bidderRequestReferer = (bidderRequest && bidderRequest.refererInfo && bidderRequest.refererInfo.referer) || '';
+    const bidderRequestReferer = bidderRequest?.refererInfo?.page || '';
     for (var i = 0, len = bidRequests.length; i < len; i++) {
       const gaxObjParams = bidRequests[i];
       serverRequests.push({

diff --git a/modules/gamoshiBidAdapter.js b/modules/gamoshiBidAdapter.js
@@ -12,7 +12,6 @@ import {
   logWarn
 } from '../src/utils.js';
 import {registerBidder} from '../src/adapters/bidderFactory.js';
-import {config} from '../src/config.js';
 import {Renderer} from '../src/Renderer.js';
 import {BANNER, VIDEO} from '../src/mediaTypes.js';
 import {includes} from '../src/polyfill.js';
@@ -34,11 +33,6 @@ export const helper = {
   startsWith: function (str, search) {
     return str.substr(0, search.length) === search;
   },
-  getTopWindowDomain: function (url) {
-    const domainStart = url.indexOf('://') + '://'.length;
-    return url.substring(domainStart, url.indexOf('/', domainStart) < 0 ? url.length : url.indexOf('/', domainStart));
-  },
-
   getMediaType: function (bid) {
     if (bid.ext) {
       if (bid.ext.media_type) {
@@ -89,14 +83,12 @@ export const spec = {
       const {adUnitCode, auctionId, mediaTypes, params, sizes, transactionId} = bidRequest;
       const baseEndpoint = params['rtbEndpoint'] || ENDPOINTS['gamoshi'];
       const rtbEndpoint = `${baseEndpoint}/r/${params.supplyPartnerId}/bidr?rformat=open_rtb&reqformat=rtb_json&bidder=prebid` + (params.query ? '&' + params.query : '');
-      let url = config.getConfig('pageUrl') || bidderRequest.refererInfo.referer;
-
       const rtbBidRequest = {
         id: auctionId,
         site: {
-          domain: helper.getTopWindowDomain(url),
-          page: url,
-          ref: bidderRequest.refererInfo.referer
+          domain: bidderRequest.refererInfo.domain,
+          page: bidderRequest.refererInfo.page,
+          ref: bidderRequest.refererInfo.ref
         },
         device: {
           ua: navigator.userAgent,

diff --git a/test/spec/modules/gamoshiBidAdapter_spec.js b/test/spec/modules/gamoshiBidAdapter_spec.js
@@ -201,10 +201,6 @@ describe('GamoshiAdapter', () => {
     it('check if you are in the top frame', () => {
       expect(helper.getTopFrame()).to.equal(0);
     });
-
-    it('verify domain parsing', () => {
-      expect(helper.getTopWindowDomain('http://www.domain.com')).to.equal('www.domain.com');
-    });
   });
 
   describe('Is String start with search', () => {
@@ -323,12 +319,16 @@ describe('GamoshiAdapter', () => {
 
     it('builds request correctly', () => {
       let bidRequest2 = utils.deepClone(bidRequest);
-      bidRequest2.refererInfo.referer = 'http://www.test.com/page.html';
+      Object.assign(bidRequest2.refererInfo, {
+        page: 'http://www.test.com/page.html',
+        domain: 'www.test.com',
+        ref: 'http://referrer.com'
+      })
       let response = spec.buildRequests([bidRequest], bidRequest2)[0];
 
       expect(response.data.site.domain).to.equal('www.test.com');
       expect(response.data.site.page).to.equal('http://www.test.com/page.html');
-      expect(response.data.site.ref).to.equal('http://www.test.com/page.html');
+      expect(response.data.site.ref).to.equal('http://referrer.com');
       expect(response.data.imp.length).to.equal(1);
       expect(response.data.imp[0].id).to.equal(bidRequest.transactionId);
       expect(response.data.imp[0].instl).to.equal(0);