New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numerous user settings added #33

Open

whyboris wants to merge 44 commits into dgarlitt:develop from whyboris:nyannyan

whyboris commented May 26, 2017 •

edited

Loading

Major changes

all package versions updated to May 2017
- cli-color now allows color nesting

Bugfixes

error report counter resets to 1 on subsequent run (Error log numbers don't reset when tests are re-run #31)
don't hide errors that occur (Template parse errors don't appear in report (Angular 2 project) #26)
- Angular 2 template parse errors no longer hidden

User options

colors for error report
exclude from error report lines that contain user-chosen strings
underline all filenames of any user-chosen filetype
hide browser version information from error log
clear screen before every run

Minor improvement

new rainbow:

‾‾--__--‾‾--__--‾‾--__--‾‾--__--‾‾--__--‾‾--__--
‾‾--__--‾‾--__--‾‾--__--‾‾--__--‾‾--__--‾‾--__--
‾‾--__--‾‾--__--‾‾--__--‾‾--__--‾‾--__--‾‾--__--
‾‾--__--‾‾--__--‾‾--__--‾‾--__--‾‾--__--‾‾--__--

A diff for passing tests, 100% coverage, and more tests for added functionality coming

idiotWu and others added 30 commits

January 5, 2017 08:21


          Sum up all tests stats (dgarlitt#24)

a284b04

* fix: sum up all tests stats
resolve dgarlitt#23

* fix: fix test

* fix: call `printStats` with summed stats

* refact: let `this.stats` inherit from `browser.lastResult`

* fix: fix `onRunComplete` test

* chore: remove useless sentences


          Update version to 0.2.5

7327cdb


          Update README.md

68da826

Add release information


          maxLogLines flag for configuration

ee75527


          removed extra lines

46e3a86


          maxLines variable added

931c51a


          maxLogLines default and function call

168a7bc


          test for setMaxLogLines

d0bc91d


          adds test for setMaxLogLines call

1e80d34


          show previously hidden errors in final report

ab5c34b


          adds reporter option to remove errors that contain matching strings

3dca56a


          adding user options for selecting color

ca4f04f


          fixed variable mis-naming

2fccc4e


          adds user option to underline filetype in error reports

517b2c8


          separating joined errors with new line

38e9bcb


          made default maxLogLines unlimited, adjusted test accordingly

82c4559


          cli-color now 1.0.0

54c80ab


          upgrade cli-color to 1.2.0 from 0.3.2

355ef4e


          updated license to a valid SPDX license expression

665c30b


          solved npm error - requires a peer of karma@>=0.9 but none was instal…

c0b3a2f

…led - by adding a devDependency of karma 1.7.0


          update all packages to May 2017 versions

257a456


          tests added

5ac1b26


          removed extra variable

6fd5509


          Merge branch 'maxloglines' into nyannyan

38034b4


          merged removelinescontaining

cfec246


          Merge branch 'showmoreerrors' into nyannyan

252c711


          merged underlinefile

84fc402


          merged usercolorsettings

e8bd248


          hide browser user setting

163fe72


          reset counter on each run


          tests passing, some test functionality disabled

5dce68b

coveralls commented May 26, 2017 •

edited

Loading

Coverage decreased (-7.5%) to 92.506% when pulling 5dce68b on whyboris:nyannyan into 68da826 on dgarlitt:master.


          set console log colors, different color options selection, tests adju…

81ebc13

…sted

coveralls commented May 27, 2017 •

edited

Loading

Coverage decreased (-7.03%) to 92.974% when pulling 81ebc13 on whyboris:nyannyan into 68da826 on dgarlitt:master.


          unsure how to write tests, please help

8f33ff2

coveralls commented May 28, 2017 •

edited

Loading

Coverage decreased (-3.7%) to 96.253% when pulling 8f33ff2 on whyboris:nyannyan into 68da826 on dgarlitt:master.


          100% coverage for types.js

a12b8f4

coveralls commented May 28, 2017 •

edited

Loading

Coverage decreased (-1.6%) to 98.361% when pulling a12b8f4 on whyboris:nyannyan into 68da826 on dgarlitt:master.


          nyanCat.js has 100% coverage

90bc1e7

coveralls commented May 28, 2017 •

edited

Loading

Coverage decreased (-0.7%) to 99.297% when pulling 90bc1e7 on whyboris:nyannyan into 68da826 on dgarlitt:master.


          many tests written for data.store exported functions

dbfc1e8

coveralls commented May 31, 2017 •

edited

Loading

Coverage decreased (-0.7%) to 99.297% when pulling dbfc1e8 on whyboris:nyannyan into 68da826 on dgarlitt:master.


          added tests - now we have 100% coverage

bd5f73d

coveralls commented Jun 1, 2017

Coverage remained the same at 100.0% when pulling bd5f73d on whyboris:nyannyan into 68da826 on dgarlitt:master.

8 similar comments

coveralls commented Jun 1, 2017

Coverage remained the same at 100.0% when pulling bd5f73d on whyboris:nyannyan into 68da826 on dgarlitt:master.

coveralls commented Jun 1, 2017

Coverage remained the same at 100.0% when pulling bd5f73d on whyboris:nyannyan into 68da826 on dgarlitt:master.

coveralls commented Jun 1, 2017 •

edited

Loading

Coverage remained the same at 100.0% when pulling bd5f73d on whyboris:nyannyan into 68da826 on dgarlitt:master.

coveralls commented Jun 1, 2017

Coverage remained the same at 100.0% when pulling bd5f73d on whyboris:nyannyan into 68da826 on dgarlitt:master.

coveralls commented Jun 1, 2017

Coverage remained the same at 100.0% when pulling bd5f73d on whyboris:nyannyan into 68da826 on dgarlitt:master.

coveralls commented Jun 1, 2017

Coverage remained the same at 100.0% when pulling bd5f73d on whyboris:nyannyan into 68da826 on dgarlitt:master.

coveralls commented Jun 1, 2017

Coverage remained the same at 100.0% when pulling bd5f73d on whyboris:nyannyan into 68da826 on dgarlitt:master.

coveralls commented Jun 1, 2017

Coverage remained the same at 100.0% when pulling bd5f73d on whyboris:nyannyan into 68da826 on dgarlitt:master.

Author

whyboris commented Jun 1, 2017

Please let me know if you would like to assimilate the functionality I am trying to add in this PR before I spend more time fixing tests (there are a few left).


          better rainbow: ‾‾--__--‾‾--__--

85cd42a

coveralls commented Jun 7, 2017 •

edited

Loading

Coverage decreased (-0.2%) to 99.774% when pulling 85cd42a on whyboris:nyannyan into 68da826 on dgarlitt:master.


          simplified the wave code

b27b42e

coveralls commented Jun 7, 2017 •

edited

Loading

Coverage remained the same at 100.0% when pulling b27b42e on whyboris:nyannyan into 68da826 on dgarlitt:master.

Owner

dgarlitt commented Jun 24, 2017 •

edited

Loading

@whyboris I would rather go back to addressing each of these additions individually. I have procrastinated on this for a while because there are several items I'd like to discuss. It seems like the open issue items (template parse errors in Angular 2 and numbering) are more important, so if you could open a single pull request for those, that would be great. Then we can address the remaining items one at a time.

The main items that I'd like to discuss are

exclude from error report lines that contain user-chosen strings
underline all filenames of any user-chosen filetype
new rainbow

But, again, it would be nice to address your open issues (#26 & #31) by itself, first.

Author

whyboris commented Jun 26, 2017

Thank you for your willingness to include changes into your project.
I'll extract the functionality from this PR and break it into pieces. I'll create a single pull request addressing these two:

Template parse errors in Angular 2 (Template parse errors don't appear in report (Angular 2 project) #26)
Reset numbering of tests on each re-run (Error log numbers don't reset when tests are re-run #31)

dgarlitt changed the base branch from master to develop

December 20, 2017 03:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet