Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl DoubleEndedIterator for Vec #156

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

hpeebles
Copy link
Contributor

@hpeebles hpeebles commented Nov 3, 2023

No description provided.

@hpeebles hpeebles requested review from roman-kashitsyn and a team as code owners November 3, 2023 09:57
@ghost
Copy link

ghost commented Nov 3, 2023

Dear @hpeebles,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA1.

If you decide to agree with it, please visit this issue and read the instructions there.

— The DFINITY Foundation

Footnotes

  1. Contributor License Agreement

@ghost
Copy link

ghost commented Nov 3, 2023

Dear @hpeebles,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA1.

If you decide to agree with it, please visit this issue and read the instructions there.

— The DFINITY Foundation

Footnotes

  1. Contributor License Agreement

@ghost
Copy link

ghost commented Nov 3, 2023

Dear @hpeebles,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA1.

If you decide to agree with it, please visit this issue and read the instructions there.

— The DFINITY Foundation

Footnotes

  1. Contributor License Agreement

@ghost ghost added cla:pending labels Nov 3, 2023
@ghost ghost added cla:agreed and removed cla:pending labels Nov 3, 2023
@hpeebles
Copy link
Contributor Author

hpeebles commented Nov 7, 2023

Does anyone know how to get the remaining 'cla' check resolved?
I'm keen to get this PR merged in!

@ielashi ielashi merged commit 1224081 into dfinity:main Nov 7, 2023
@ielashi
Copy link
Contributor

ielashi commented Nov 7, 2023

@hpeebles Looks like your comment somehow triggered something and I was able to merge the PR :)

@hpeebles hpeebles deleted the double_ended_iterator branch November 7, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants