-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow users to get the principal id of the current identity #1046
Merged
Merged
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
546fdd2
init
ee58d25
add message file
c4042ae
fmt and comma
9bbd82c
Merge branch 'master' into pshahi/identity-export-principal
p-shahi 239d756
Merge branch 'master' into pshahi/identity-export-principal
p-shahi b965857
a few tests
5275cc6
Merge branch 'pshahi/identity-export-principal' of github.com:dfinity…
314c255
rename
8da8479
rename in tests
771c6ac
Merge branch 'master' into pshahi/identity-export-principal
p-shahi 7caa5dd
Merge branch 'master' into pshahi/identity-export-principal
p-shahi 23845a0
Merge branch 'master' into pshahi/identity-export-principal
p-shahi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
use crate::lib::environment::Environment; | ||
use crate::lib::error::DfxResult; | ||
use crate::lib::identity::identity_manager::IdentityManager; | ||
use crate::lib::message::UserMessage; | ||
use clap::{App, ArgMatches, SubCommand}; | ||
|
||
pub fn construct() -> App<'static, 'static> { | ||
SubCommand::with_name("get-principal-id").about(UserMessage::GetPrincipalId.to_str()) | ||
} | ||
|
||
pub fn exec(env: &dyn Environment, _args: &ArgMatches<'_>) -> DfxResult { | ||
let identity = IdentityManager::new(env)?.instantiate_selected_identity()?; | ||
let principal_id = identity.sender()?; | ||
println!("{}", principal_id.to_text()); | ||
Ok(()) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lsgunnlsgunn may I request you review the command name and help text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.