Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix over-eager side conditions #413

Merged
merged 1 commit into from
May 15, 2019
Merged

Fix over-eager side conditions #413

merged 1 commit into from
May 15, 2019

Conversation

rossberg
Copy link
Contributor

Fixes #402.

@rossberg rossberg requested a review from crusso May 15, 2019 11:22
Copy link
Contributor

@crusso crusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rossberg rossberg merged commit c154e57 into master May 15, 2019
@rossberg rossberg deleted the rec-bug branch May 15, 2019 13:12
dfinity-bot added a commit that referenced this pull request May 24, 2023
## Changelog for candid:
Branch: master
Commits: [dfinity/candid@f7166f47...9301221a](dfinity/candid@f7166f4...9301221)

* [`51c00478`](dfinity/candid@51c0047) spec: support composite query ([dfinity/candid⁠#420](https://togithub.com/dfinity/candid/issues/420))
* [`74869398`](dfinity/candid@7486939) fix recursion test ([dfinity/candid⁠#425](https://togithub.com/dfinity/candid/issues/425))
* [`eb31f888`](dfinity/candid@eb31f88) Use Arc<Type> with `arc_type` feature ([dfinity/candid⁠#407](https://togithub.com/dfinity/candid/issues/407))
* [`b9d6cbff`](dfinity/candid@b9d6cbf) support custom candid path for export_service ([dfinity/candid⁠#421](https://togithub.com/dfinity/candid/issues/421))
* [`fa29c70d`](dfinity/candid@fa29c70) Add config options for Rust binding ([dfinity/candid⁠#422](https://togithub.com/dfinity/candid/issues/422))
* [`f31396d8`](dfinity/candid@f31396d) Bump webpack from 5.24.4 to 5.76.0 in /tools/ui ([dfinity/candid⁠#413](https://togithub.com/dfinity/candid/issues/413))
* [`9301221a`](dfinity/candid@9301221) release ([dfinity/candid⁠#430](https://togithub.com/dfinity/candid/issues/430))
mergify bot pushed a commit that referenced this pull request May 24, 2023
## Changelog for candid:
Branch: master
Commits: [dfinity/candid@f7166f47...9301221a](dfinity/candid@f7166f4...9301221)

* [`51c00478`](dfinity/candid@51c0047) spec: support composite query ([dfinity/candid⁠#420](https://togithub.com/dfinity/candid/issues/420))
* [`74869398`](dfinity/candid@7486939) fix recursion test ([dfinity/candid⁠#425](https://togithub.com/dfinity/candid/issues/425))
* [`eb31f888`](dfinity/candid@eb31f88) Use Arc<Type> with `arc_type` feature ([dfinity/candid⁠#407](https://togithub.com/dfinity/candid/issues/407))
* [`b9d6cbff`](dfinity/candid@b9d6cbf) support custom candid path for export_service ([dfinity/candid⁠#421](https://togithub.com/dfinity/candid/issues/421))
* [`fa29c70d`](dfinity/candid@fa29c70) Add config options for Rust binding ([dfinity/candid⁠#422](https://togithub.com/dfinity/candid/issues/422))
* [`f31396d8`](dfinity/candid@f31396d) Bump webpack from 5.24.4 to 5.76.0 in /tools/ui ([dfinity/candid⁠#413](https://togithub.com/dfinity/candid/issues/413))
* [`9301221a`](dfinity/candid@9301221) release ([dfinity/candid⁠#430](https://togithub.com/dfinity/candid/issues/430))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading type error
3 participants