Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly use python2 #9

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Explicitly use python2 #9

merged 2 commits into from
Jan 28, 2020

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Jan 27, 2020

Otherwise this code fails with python3.

Fixes #8

ggreif added 2 commits January 27, 2020 22:41
@ggreif
Explicitly use python2
ce1b1f9 
Otherwise this code fails with `python3`.

Fixes #8
@ggreif
Use python2
841174f
@ggreif ggreif marked this pull request as ready for review January 27, 2020 21:48
@ggreif ggreif requested a review from a team as a code owner January 27, 2020 21:48
@ggreif ggreif added the bug Something isn't working label Jan 27, 2020
@ggreif
Copy link
Contributor Author

ggreif commented Jan 27, 2020

I know that python2 is nearing EOL, but moving to python3 should be tracked company-wide. So this is just a stopgap.

@ggreif ggreif merged commit cbbbfba into master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

specify python version when setting env variables
1 participant
@ggreif