Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): Add time synchronization check to setupOS #3433

Merged
merged 6 commits into from
Jan 16, 2025
Merged

feat(node): Add time synchronization check to setupOS #3433

merged 6 commits into from
Jan 16, 2025

Conversation

andrewbattat
Copy link
Member

NODE-1504

  • Force the RTC to keep time in UTC
  • Add a check for if system clock is synchronized

@andrewbattat andrewbattat self-assigned this Jan 13, 2025
@github-actions github-actions bot added the feat label Jan 13, 2025
@andrewbattat andrewbattat marked this pull request as ready for review January 14, 2025 20:10
@andrewbattat andrewbattat requested a review from a team as a code owner January 14, 2025 20:10
@github-actions github-actions bot added the @node label Jan 14, 2025
Bownairo
Bownairo approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@Bownairo Bownairo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one quick change, but otherwise looks OK to me

ic-os/components/setupos-scripts/check-ntp.sh Outdated Show resolved Hide resolved
@andrewbattat andrewbattat added this pull request to the merge queue Jan 16, 2025
Merged via the queue into master with commit 51f818e Jan 16, 2025
25 checks passed
@andrewbattat andrewbattat deleted the andrew/setupos-timing-check branch January 16, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bownairo Bownairo Bownairo approved these changes

Assignees

@andrewbattat andrewbattat

Labels
feat @node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewbattat @Bownairo