Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(governance): Create changelog files for all of our canisters. #3388

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

daniel-wong-dfinity-org
Copy link
Contributor

@daniel-wong-dfinity-org daniel-wong-dfinity-org commented Jan 9, 2025

Also, moves the description of the process from governance/unreleased_changelog.md to nervous_system/changelog_process.md. Other files point to changelog_process.md.

Future Work

In the next PRs in this vein, add support for SNS our tools. In particular, proposal generation, and moving content from unreleased_changelog.md to CHANGELOG.md.

References

👈 Previous PR

@daniel-wong-dfinity-org daniel-wong-dfinity-org force-pushed the changelog-all-the-things-daniel-wong branch from 8719971 to b975506 Compare January 9, 2025 19:10
@github-actions github-actions bot added the docs label Jan 9, 2025
@daniel-wong-dfinity-org daniel-wong-dfinity-org marked this pull request as ready for review January 10, 2025 14:19
@daniel-wong-dfinity-org daniel-wong-dfinity-org requested a review from a team as a code owner January 10, 2025 14:19
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).

To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:

  1. Done.

  2. No canister behavior changes.

@jasonz-dfinity jasonz-dfinity added this pull request to the merge queue Jan 10, 2025
Merged via the queue into master with commit b519258 Jan 10, 2025
34 checks passed
@jasonz-dfinity jasonz-dfinity deleted the changelog-all-the-things-daniel-wong branch January 10, 2025 16:42
github-merge-queue bot pushed a commit that referenced this pull request Jan 10, 2025
…oposals from unreleased_changelog.md. (#3405)

# Future Work

Add entry to SNS CHANGELOG.md files from unreleased_changelog.md, like
how we do with NNS. This just involves making some (small?) changes to
the add-release-to-changelog.sh script.

# References

[👈 Previous PR][prev]

[prev]: #3388

---------

Co-authored-by: Max Summe <maximilian.summe@dfinity.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants