chore: CON-1434 Increment metric in case of NiDkgTag mismatches
#3329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sawchord
approved these changes
Jan 7, 2025
daniel-wong-dfinity-org
pushed a commit
that referenced
this pull request
Jan 7, 2025
) With #3039 we will start to serialize maps of the form `(nidkg_tag, nidkg_transcript)` as a vector of `nidkg_transcript`s. This is fine since the NiDkg tag is also part of the NiDkg transcript. More generally, the change makes the assumption `nidkg_tag == nidkg_transcript.tag` explicit. As an extra pre-caution, this PR adds a log and metric to increase our confidence that this assumption already holds today (and thus that the change in #3039 is safe to roll out).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #3039 we will start to serialize maps of the form
(nidkg_tag, nidkg_transcript)as a vector ofnidkg_transcripts. This is fine since the NiDkg tag is also part of the NiDkg transcript. More generally, the change makes the assumptionnidkg_tag == nidkg_transcript.tagexplicit.As an extra pre-caution, this PR adds a log and metric to increase our confidence that this assumption already holds today (and thus that the change in #3039 is safe to roll out).