Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ICP-ledger: FI-1440: Implement V4 for ICP ledger - migrate balances to stable structures #3314

Open
wants to merge 72 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 64 commits
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
78fa838
stable balances
maciejdfinity Nov 29, 2024
17135dd
remove account trimming
maciejdfinity Nov 29, 2024
996abf8
clippy
maciejdfinity Nov 29, 2024
84551a9
build fix
maciejdfinity Nov 29, 2024
1005cb5
clippy
maciejdfinity Nov 29, 2024
33cfeb1
clippy
maciejdfinity Nov 29, 2024
e0ad62b
clippy
maciejdfinity Nov 29, 2024
9de583d
Revert "clippy"
maciejdfinity Nov 30, 2024
5562268
Revert "clippy"
maciejdfinity Nov 30, 2024
a917348
Revert "clippy"
maciejdfinity Nov 30, 2024
bfdf78e
Revert "build fix"
maciejdfinity Nov 30, 2024
2749fe0
Revert "clippy"
maciejdfinity Nov 30, 2024
40062fc
Revert "remove account trimming"
maciejdfinity Nov 30, 2024
fccd631
disable balance/approval pruning for icrc ledger
maciejdfinity Dec 2, 2024
c9d957e
fix comments
maciejdfinity Dec 2, 2024
d729ebe
clippy
maciejdfinity Dec 2, 2024
e3bb73f
balances_len not a member fn
maciejdfinity Dec 2, 2024
0dca3a4
update canbench results
maciejdfinity Dec 2, 2024
362bc8a
update mainnet u64 wasm, add v1 and v2 wasms
maciejdfinity Dec 2, 2024
b528d1f
add v1 and v2 to bazel
maciejdfinity Dec 2, 2024
2634596
add v2 and mainnet testing to some tests
maciejdfinity Dec 3, 2024
c519690
add test
maciejdfinity Dec 3, 2024
a6d3efd
frozen test
maciejdfinity Dec 3, 2024
c0b5b67
add u256 v1 and v2 ledgers
maciejdfinity Dec 3, 2024
3aa03ac
test upgrade from v1 not possible
maciejdfinity Dec 3, 2024
192fe5c
fix log message
maciejdfinity Dec 3, 2024
43e3e63
clippy
maciejdfinity Dec 3, 2024
813da56
remove account trimming init and upgrade args
maciejdfinity Dec 4, 2024
ab6fbc1
clippy
maciejdfinity Dec 4, 2024
be7510f
clippy
maciejdfinity Dec 4, 2024
ed8a4a9
Merge branch 'master' into maciej-icrc-v4
maciejdfinity Dec 4, 2024
98f81db
Merge branch 'master' into maciej-icrc-v4
maciejdfinity Dec 5, 2024
8a3bf31
Merge branch 'master' into maciej-icrc-v4
maciejdfinity Dec 11, 2024
cf1d502
build fix
maciejdfinity Dec 11, 2024
33a0fd6
fix comments
maciejdfinity Dec 11, 2024
c730fc2
rename function
maciejdfinity Dec 11, 2024
d3b690d
implement v4 for icp
maciejdfinity Dec 11, 2024
e22994c
fix comments
maciejdfinity Dec 11, 2024
b36f5b6
update cketh hash
maciejdfinity Dec 11, 2024
c59b7fa
remove account listing from nns inspector
maciejdfinity Dec 11, 2024
377eb72
fix tests
maciejdfinity Dec 11, 2024
5239713
tokens serialization tests
maciejdfinity Dec 11, 2024
e6acc16
small refactor
maciejdfinity Dec 12, 2024
0325b46
add some tests
maciejdfinity Dec 12, 2024
2ab57f1
refactor tests
maciejdfinity Dec 12, 2024
8388353
more tests
maciejdfinity Dec 12, 2024
a35b417
remove max accounts from ledger and tests
maciejdfinity Dec 12, 2024
a5847ff
remove default values for max accounts
maciejdfinity Dec 12, 2024
e52cc78
build fix
maciejdfinity Dec 12, 2024
76d3131
fix comments
maciejdfinity Dec 12, 2024
49e7bb8
update ICRC v3 git commit and wasm hash
maciejdfinity Dec 13, 2024
563eafe
Update rs/ledger_suite/icrc1/ledger/src/main.rs
maciejdfinity Dec 13, 2024
259badc
Merge branch 'master' into maciej-icrc-v4
maciejdfinity Dec 18, 2024
91a092e
fix sm tests
maciejdfinity Dec 18, 2024
54bf390
fix upgrade downgrade tests
maciejdfinity Dec 18, 2024
892b03c
reenable ignored tests
maciejdfinity Dec 18, 2024
49ebc99
fix golden state tests
maciejdfinity Dec 18, 2024
82bd3a5
vary transfer amount in migration test
maciejdfinity Dec 20, 2024
5e64eeb
vary transfer amount in migration test
maciejdfinity Dec 20, 2024
13c7ef3
Merge branch 'master' into maciej-icrc-v4
maciejdfinity Dec 20, 2024
31123a5
Merge branch 'master' into maciej-icrc-v4
maciejdfinity Dec 23, 2024
a0abf82
fix test name
maciejdfinity Dec 30, 2024
8308cd5
Merge branch 'maciej-icrc-v4' into maciej-icp-v4
maciejdfinity Dec 30, 2024
45024a4
fix tests
maciejdfinity Dec 30, 2024
637dc98
Merge branch 'master' into maciej-icp-v4
maciejdfinity Jan 7, 2025
d8b4e05
remove trimming
maciejdfinity Jan 7, 2025
223e17d
reenable disabled tests
maciejdfinity Jan 7, 2025
e07aa5a
Update rs/ledger_suite/icp/ledger/src/main.rs
maciejdfinity Jan 8, 2025
624d94d
bump MAX_INSTRUCTIONS_PER_UPGRADE to 250B
maciejdfinity Jan 8, 2025
da71dda
fix golden nns tests
maciejdfinity Jan 8, 2025
4299d4d
Merge branch 'master' into maciej-icp-v4
maciejdfinity Jan 9, 2025
1604074
cargo lock
maciejdfinity Jan 9, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 24 additions & 25 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions WORKSPACE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ canisters(
"registry": "registry-canister.wasm.gz",
"governance": "governance-canister.wasm.gz",
"ledger": "ledger-canister_notify-method.wasm.gz",
"ledger_v1": "ledger-canister_notify-method.wasm.gz",
"ledger_v2": "ledger-canister_notify-method.wasm.gz",
"archive": "ledger-archive-node-canister.wasm.gz",
"index": "ic-icp-index-canister.wasm.gz",
"root": "root-canister.wasm.gz",
Expand All @@ -26,9 +28,13 @@ canisters(
"sns-wasm": "sns-wasm-canister.wasm.gz",
"ck_btc_archive": "ic-icrc1-archive.wasm.gz",
"ck_btc_ledger": "ic-icrc1-ledger.wasm.gz",
"ck_btc_ledger_v1": "ic-icrc1-ledger.wasm.gz",
"ck_btc_ledger_v2": "ic-icrc1-ledger.wasm.gz",
"ck_btc_index": "ic-icrc1-index-ng.wasm.gz",
"ck_eth_archive": "ic-icrc1-archive-u256.wasm.gz",
"ck_eth_ledger": "ic-icrc1-ledger-u256.wasm.gz",
"ck_eth_ledger_v1": "ic-icrc1-ledger-u256.wasm.gz",
"ck_eth_ledger_v2": "ic-icrc1-ledger-u256.wasm.gz",
"ck_eth_index": "ic-icrc1-index-ng-u256.wasm.gz",
"sns_root": "sns-root-canister.wasm.gz",
"sns_governance": "sns-governance-canister.wasm.gz",
Expand All @@ -43,6 +49,8 @@ canisters(
"registry": "mainnet_nns_registry_canister",
"governance": "mainnet_nns_governance_canister",
"ledger": "mainnet_icp_ledger_canister",
"ledger_v1": "mainnet_icp_ledger_canister-v1",
"ledger_v2": "mainnet_icp_ledger_canister-v2",
"archive": "mainnet_icp_ledger-archive-node-canister",
"index": "mainnet_icp_index_canister",
"root": "mainnet_nns_root-canister",
Expand All @@ -52,9 +60,13 @@ canisters(
"sns-wasm": "mainnet_nns_sns-wasm-canister",
"ck_btc_archive": "mainnet_ckbtc_ic-icrc1-archive",
"ck_btc_ledger": "mainnet_ckbtc_ic-icrc1-ledger",
"ck_btc_ledger_v1": "mainnet_ckbtc_ic-icrc1-ledger-v1",
"ck_btc_ledger_v2": "mainnet_ckbtc_ic-icrc1-ledger-v2",
"ck_btc_index": "mainnet_ckbtc-index-ng",
"ck_eth_archive": "mainnet_cketh_ic-icrc1-archive-u256",
"ck_eth_ledger": "mainnet_cketh_ic-icrc1-ledger-u256",
"ck_eth_ledger_v1": "mainnet_cketh_ic-icrc1-ledger-u256-v1",
"ck_eth_ledger_v2": "mainnet_cketh_ic-icrc1-ledger-u256-v2",
"ck_eth_index": "mainnet_cketh-index-ng",
"sns_root": "mainnet_sns-root-canister",
"sns_governance": "mainnet_sns-governance-canister",
Expand Down
24 changes: 24 additions & 0 deletions mainnet-canister-revisions.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,14 @@
"rev": "2190613d3b5bcd9b74c382b22d151580b8ac271a",
"sha256": "25071c2c55ad4571293e00d8e277f442aec7aed88109743ac52df3125209ff45"
},
"ck_btc_ledger_v1": {
"rev": "d4ee25b0865e89d3eaac13a60f0016d5e3296b31",
"sha256": "a170bfdce5d66e751a3cc03747cb0f06b450af500e75e15976ec08a3f5691f4c"
},
"ck_btc_ledger_v2": {
"rev": "e54d3fa34ded227c885d04e64505fa4b5d564743",
"sha256": "3d808fa63a3d8ebd4510c0400aa078e99a31afaa0515f0b68778f929ce4b2a46"
},
"ck_eth_archive": {
"rev": "2190613d3b5bcd9b74c382b22d151580b8ac271a",
"sha256": "2d25f7831894100d48aa9043c65e87c293487523f0958c15760027d004fbbda9"
Expand All @@ -27,6 +35,14 @@
"rev": "2190613d3b5bcd9b74c382b22d151580b8ac271a",
"sha256": "9637743e1215a4db376a62ee807a0986faf20833be2b332df09b3d5dbdd7339e"
},
"ck_eth_ledger_v1": {
"rev": "d4ee25b0865e89d3eaac13a60f0016d5e3296b31",
"sha256": "e6072806ae22868ee09c07923d093b1b0b687dba540d22cfc1e1a5392bfcca46"
},
"ck_eth_ledger_v2": {
"rev": "e54d3fa34ded227c885d04e64505fa4b5d564743",
"sha256": "98a7b7391608dc4a554d6964bad24157b6aaf890a05bbaad3fcc92033d9c7b02"
},
"cycles-minting": {
"rev": "ee52ab3056cf5f39b09b08de70bdd20485c8b2dc",
"sha256": "bbb8995cb749ba9e2c721ff507f5e5313f32e69b1adf3df20e3901ed56a70b42"
Expand All @@ -47,6 +63,14 @@
"rev": "7c6309cb5bec7ab28ed657ac7672af08a59fc1ba",
"sha256": "a9ed1cb9dda555e0fc1038825eb7b3a6b366f17aa4b88575184c7537e864e551"
},
"ledger_v1": {
"rev": "6dcfafb491092704d374317d9a72a7ad2475d7c9",
"sha256": "4fe38a91a3130e9d8b39e3413ae3b3f46c40d3fbd507df1b6092f962d970a7ea"
},
"ledger_v2": {
"rev": "dac2f36f96d7549d82fa8e3c714979255ce57afd",
"sha256": "50c05fd687883fe788c0bb91996de358d8f856ba56088c6ff47767ea853001d7"
},
"lifeline": {
"rev": "a0207146be211cdff83321c99e9e70baa62733c7",
"sha256": "76978515223287ece643bc7ca087eb310412b737e2382a73b8ae55fcb458da5b"
Expand Down
2 changes: 0 additions & 2 deletions rs/ethereum/ledger-suite-orchestrator/src/scheduler/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -932,8 +932,6 @@ fn icrc1_ledger_init_arg(
),
max_memo_length: Some(MAX_MEMO_LENGTH),
feature_flags: Some(ICRC2_FEATURE),
maximum_number_of_accounts: None,
accounts_overflow_trim_quantity: None,
}
}

Expand Down
Loading
Loading