Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(consensus): disable hashes in blocks feature #3302

Merged
merged 1 commit into from
Dec 30, 2024
Merged

fix(consensus): disable hashes in blocks feature #3302

merged 1 commit into from
Dec 30, 2024

Conversation

kpop-dfinity
Copy link
Contributor

There is a problem with the current implementation, we are thus disabling the feature while we fix the issue.

@github-actions github-actions bot added the fix label Dec 30, 2024
@kpop-dfinity kpop-dfinity marked this pull request as ready for review December 30, 2024 08:55
@kpop-dfinity kpop-dfinity requested a review from a team as a code owner December 30, 2024 08:55
@kpop-dfinity kpop-dfinity changed the title fix(consensus): disable hashes in block feature fix(consensus): disable hashes in blocks feature Dec 30, 2024
basvandijk
basvandijk approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@basvandijk basvandijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will force merge this in without approval from the networking team (since they're on PTO). This was discussed with Kamil and David.

@basvandijk basvandijk merged commit 5716305 into master Dec 30, 2024
28 checks passed
@basvandijk basvandijk deleted the kpop/hashes/disable branch December 30, 2024 09:11
@altkdf altkdf mentioned this pull request Jan 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derlerd-dfinity derlerd-dfinity derlerd-dfinity approved these changes

@basvandijk basvandijk basvandijk approved these changes

Assignees
No one assigned
Labels
fix @networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpop-dfinity @basvandijk @derlerd-dfinity