Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(boundary): rate-limit canister improvements #3291

Merged
merged 10 commits into from
Dec 27, 2024
Merged

feat(boundary): rate-limit canister improvements #3291

merged 10 commits into from
Dec 27, 2024

Conversation

nikolay-komarevskiy
Copy link
Contributor

@nikolay-komarevskiy nikolay-komarevskiy commented Dec 24, 2024 •
edited
Loading

Improvements to rate-limit canister:

  • combined numerous metrics variables into one single struct CanisterMetrics
  • added candid compatibility test, which compares interface .did against the actual interface in Rust
  • added canister logging, used e.g. to log errors when fetching API nodes from the registry canister
  • use safe checked_add to error in case of overflows
  • removed some unused deps

@github-actions github-actions bot added the feat label Dec 24, 2024
@nikolay-komarevskiy nikolay-komarevskiy force-pushed the komarevskiy/rate-limit-improvements branch 2 times, most recently from cae4425 to 5dd588a Compare December 24, 2024 16:26
@nikolay-komarevskiy nikolay-komarevskiy force-pushed the komarevskiy/rate-limit-improvements branch from 42708e8 to 107f2bd Compare December 24, 2024 16:36
@nikolay-komarevskiy nikolay-komarevskiy added the CI_OVERRIDE_DIDC_CHECK Skips the backwards compatibility didc check (explain in PR description why) label Dec 24, 2024
@nikolay-komarevskiy nikolay-komarevskiy marked this pull request as ready for review December 24, 2024 18:59
@nikolay-komarevskiy nikolay-komarevskiy requested a review from a team as a code owner December 24, 2024 18:59
@nikolay-komarevskiy nikolay-komarevskiy added this pull request to the merge queue Dec 27, 2024
Merged via the queue into master with commit 74bc4ed Dec 27, 2024
29 checks passed
@nikolay-komarevskiy nikolay-komarevskiy deleted the komarevskiy/rate-limit-improvements branch December 27, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blind-oracle blind-oracle blind-oracle approved these changes

Assignees
No one assigned
Labels
@boundary-node CI_OVERRIDE_DIDC_CHECK Skips the backwards compatibility didc check (explain in PR description why) feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikolay-komarevskiy @blind-oracle