fix(nns): Revert spawn state when ledger unavailable and drop lock #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8b83d2 to
893f5fa
Compare
893f5fa to
6297a92
Compare
jasonz-dfinity
approved these changes
Jan 2, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
A neuron was locked, which logged `Inflight commands: {
17912780790050115461: NeuronInFlightCommand { timestamp: 1728911670,
command: Some( Spawn( NeuronId { id: 17912780790050115461, }, ), ), },
}`
We identified the account as:
https://dashboard.internetcomputer.org/account/9765cc69bd6580023bee8fa8280fb630977b9f850da49d73cddcb99512272abb
And the neuron can be seen here:
https://dashboard.internetcomputer.org/neuron/17912780790050115461
As can be seen, no ICP was minted, but the neuron's cached stake was set
and maturity was cleared. The fix is to mint the ICP and unlock the
neuron.
Fix to prevent this from happening in the future is here:
#3226
daniel-wong-dfinity-org
pushed a commit
that referenced
this pull request
Jan 7, 2025
A neuron was locked, which logged `Inflight commands: {
17912780790050115461: NeuronInFlightCommand { timestamp: 1728911670,
command: Some( Spawn( NeuronId { id: 17912780790050115461, }, ), ), },
}`
We identified the account as:
https://dashboard.internetcomputer.org/account/9765cc69bd6580023bee8fa8280fb630977b9f850da49d73cddcb99512272abb
And the neuron can be seen here:
https://dashboard.internetcomputer.org/neuron/17912780790050115461
As can be seen, no ICP was minted, but the neuron's cached stake was set
and maturity was cleared. The fix is to mint the ICP and unlock the
neuron.
Fix to prevent this from happening in the future is here:
#3226
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes an edge case where a neuron can become locked when the ledger is unavailable during a neuron operation (such as during an upgrade).
If the neuron happens to spawn during a ledger upgrade, the neuron will become locked, and therefore stuck.