fix(sns): SNS Gov should not accept an upgrade path from SNS-W that contains duplicate versions #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a6e6012 to
223a1f2
Compare
9f17274 to
1691020
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
…#2836) This PR moves `temporarily_lock_refresh_cached_upgrade_steps`, `should_refresh_cached_upgrade_steps`, and `should_refresh_cached_upgrade_steps` into the already existing `cached_upgrade_steps.rs` file. The benefit of this is improved organization – pretty much all the upgrade-steps-related stuff is now in one small file. [Next PR →](#2839) ## Note We don't do this very often in SNS governance, but I think it would be a good habit to get into. These giant files we have are intimidating and make it hard to find what you're looking for. Another case where we do this currently is in `upgrade_journal.rs`
223a1f2 to
73693a5
Compare
max-dfinity
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An upgrade path with duplicate versions from SNS-W would almost certainly be erroneous, and likely to cause the SNS to enter an infinite upgrade loop, which could be unrecoverable. We also may make the assumption in various places that the upgrade steps will not have duplicates, so it's good to enforce that.
← Previous PR