chore(errors): create client-facing errors #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43b0cb8 to
90d1f2b
Compare
f5a0eeb to
8c363ba
Compare
8c363ba to
fb9b2c4
Compare
rikonor
approved these changes
Dec 13, 2024
654c591 to
9ae60f1
Compare
9ae60f1 to
d43134f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR differentiates how errors are logged internally and exposed externally. In particular, it introduces an HTML rendering for all errors for HTTP gateway requests.
It introduces a new internal error called HttpGatewayError that captures all errors that happen in the
http-gatewaylibrary. Externally, we expose all these errors as a "service unavailable" as they are not actionable for the clients. We onlytreat the
no_healthy_nodeserror specially as it occurs during subnet upgrades. We also givecanister_not_foundspecial treatment, even though it should actually not occur asic-gatewayperforms a check before handing the request off to thehttp-gatewaylibrary.