This repository has been archived by the owner on May 23, 2022. It is now read-only.
Add set-controller to doc #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
p-shahi
reviewed
Sep 29, 2020
Comment on lines
619
to
627
| You can use the `+dfx canister set-controller+` command to specify a user or canister as the controlling identity for a specific canister. | ||
|
|
||
| For example, you might create a new identity called `+pubsadmin+` then run the `+dfx canister set-controller+` to specify that you want the `+pubsadmin+` identity to be the controller of the `+my_wallet+` canister by running the following commands: | ||
|
|
||
| .... | ||
| dfx identity new pubsadmin | ||
| dfx canister set-controller my_wallet pubsadmin | ||
| .... | ||
|
|
There was a problem hiding this comment.
Based on the discussion we had in the architecture meeting, you would not need to do set controller on the wallet canister. The get-principal command will be sent to the Onboarding team and they will set the controller to the user provided principal.
Therefore, this example should change to just show setting the controller of a normal hello canister or similar
p-shahi
reviewed
Sep 29, 2020
|
|
||
| Use the `+dfx canister set-controller+` command to specify the identity name or principal to use as the new **controller** for a specified canister on the Internet Computer network. | ||
| A controller identity has special rights to manage the canister it controls. | ||
| For example, only a controlling identity can be used to upgrade or transfer cycles to the canister under its control. |
There was a problem hiding this comment.
This is true but you can also specify a custodian in the wallet canister so multiple identities can transfer cycles to it. Therefore, I would just remove this and just specify that only the controller may install, reinstall, upgrade etc.
p-shahi
approved these changes
Sep 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add CLI reference for new subcommand