Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix semicolon in did parser #354

Merged
merged 2 commits into from
Jun 7, 2022
Merged

fix semicolon in did parser #354

merged 2 commits into from
Jun 7, 2022

Conversation

chenyan-dfinity
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity commented Jun 7, 2022

Fix #353

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Benchmark for c555139

Click to view benchmark
Test Base PR %
Blob/&str 283.4±102.26µs 274.2±85.01µs -3.25%
Blob/ByteBuf 231.6±59.83µs 229.9±56.11µs -0.73%
Blob/Bytes 168.4±63.91µs 158.0±45.28µs -6.18%
Blob/String 338.3±85.10µs 346.1±88.70µs +2.31%
Collections/vec (text, nat) 87.1±4.24ms 90.5±3.25ms +3.90%
Collections/vec int 41.9±1.70ms 42.9±1.73ms +2.39%
Collections/vec int64 26.5±1.49ms 29.7±1.46ms +12.08%
Collections/vec nat8 22.7±0.95ms 22.1±0.69ms -2.64%
option list/1024 3.0±0.11ms 2.9±0.08ms -3.33%
profiles/1024 6.1±0.37ms 5.6±0.17ms -8.20%
variant list/1024 3.0±0.12ms 3.0±0.21ms 0.00%

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Benchmark for 36f6ec6

Click to view benchmark
Test Base PR %
Blob/&str 273.7±84.66µs 272.2±83.63µs -0.55%
Blob/ByteBuf 204.9±64.00µs 199.1±52.25µs -2.83%
Blob/Bytes 127.7±38.16µs 129.7±37.00µs +1.57%
Blob/String 302.3±94.68µs 303.4±96.88µs +0.36%
Collections/vec (text, nat) 87.2±1.59ms 87.1±1.07ms -0.11%
Collections/vec int 39.2±0.34ms 39.8±0.09ms +1.53%
Collections/vec int64 26.8±0.33ms 28.0±1.69ms +4.48%
Collections/vec nat8 20.4±0.18ms 20.6±0.11ms +0.98%
option list/1024 2.7±0.01ms 2.7±0.02ms 0.00%
profiles/1024 5.3±0.03ms 5.3±0.06ms 0.00%
variant list/1024 2.7±0.04ms 2.7±0.02ms 0.00%

@chenyan-dfinity chenyan-dfinity merged commit 0a2346e into master Jun 7, 2022
@chenyan-dfinity chenyan-dfinity deleted the fix-353 branch June 7, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow optional semicolon for actor
1 participant