support reference types #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyan-dfinity
commented
Dec 18, 2020
mergify bot
pushed a commit
to dfinity/motoko
that referenced
this pull request
Feb 17, 2021
This PR: * Bumps candid to get the latest test suite, including dfinity/candid#153 * Validate `service` and `func` types in the type table. Fixes: #2231. In particular - method names are valid UTF-8 - method names are in strictly ascending order - method types are indeed function type - function annotations must be 0 or 1. * Updates IDL-Motoko.mo to not use the field hash when encoding otherwise unsupported Candid method names (such as ☃) This means that our type export is less surjective; see #1668 for a discussion of a possible fix. * Update `mo_id/*.rs` accordingly * Test cases for importing unrepresentable Candid types, including a new error code and a long error description. * The test suite runner will ignore such unsupported test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
didc encode