Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default fees for mainnet/testnet networks #376

Merged
merged 13 commits into from
Mar 5, 2025
Merged

Conversation

maksymar
Copy link
Contributor

@maksymar maksymar commented Mar 5, 2025

This PR adds auto-setup for fees if not explicitly provided during initialisation.

Fees values hardcoded depending on config network (mainnet/testnet) and rely on docs.

Copy link

github-actions bot commented Mar 5, 2025

canbench 🏋 (dir: .) cd5eec5 2025-03-05 18:00:57 UTC

ℹ️ No significant performance changes detected 👍
./canbench_results.yml is up to date

~/work/bitcoin-canister/bitcoin-canister/scripts ~/work/bitcoin-canister/bitcoin-canister
~/work/bitcoin-canister/bitcoin-canister

---------------------------------------------------

Benchmark: insert_300_blocks
  total:
    instructions: 475.59 M (no change)
    heap_increase: 10 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: get_metrics
  total:
    instructions: 7.63 M (no change)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers
  total:
    instructions: 3.11 B (no change)
    heap_increase: 1 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers_multiple_times
  total:
    instructions: 11.40 B (no change)
    heap_increase: 7 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: pre_upgrade_with_many_unstable_blocks
  total:
    instructions: 6.00 B (no change)
    heap_increase: 4097 pages (no change)
    stable_memory_increase: 1792 pages (no change)

  serialize_blocktree (scope):
    instructions: 2.40 B (no change)
    heap_increase: 2048 pages (no change)
    stable_memory_increase: 0 pages (no change)

  serialize_blocktree_flatten (scope):
    instructions: 183.74 K (no change)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

  serialize_blocktree_serialize_seq (scope):
    instructions: 2.40 B (no change)
    heap_increase: 2048 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

@maksymar maksymar marked this pull request as ready for review March 5, 2025 14:46
@maksymar maksymar requested a review from a team as a code owner March 5, 2025 14:46
@maksymar maksymar enabled auto-merge (squash) March 5, 2025 17:57
@maksymar maksymar merged commit e19928c into master Mar 5, 2025
28 checks passed
@maksymar maksymar deleted the maksym/fees-rs branch March 5, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants