-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add suppression ability #72
Conversation
Codecov Report
@@ Coverage Diff @@
## main #72 +/- ##
==========================================
+ Coverage 87.32% 88.05% +0.73%
==========================================
Files 3 3
Lines 418 452 +34
==========================================
+ Hits 365 398 +33
- Misses 53 54 +1
|
Needs reference documentation in README.md in the Disabling a rule on a referenceTo turn off a rule on a specific project or package reference, add the relevant RTxxxx code to a <ProjectReference Include="../Other/Project.csproj" NoWarn="RT0002" /> In reply to: 1720026036 |
I would also move the In reply to: 1720026036 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have realized that the nowarn info does not have to be passed to the analyzer. Just references with appropriate nowarn attribute will be swallowed in the msbuild task |
Yea that's what I was thinking. Just filter it on the "Declared" side. |
OTOH the current implementation would allow to report useless suppressions. |
Verified this allowed me to fix RT0002 issues in an affected repo. Found a NullRefException, sending PR for it. |
Fixes #61