Remove volatility from schema manifest file #160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema paths written to the schema manifest are full absolute paths. This introduces volatility in the build, makes it non-reproducible and non-relocatable, since the full absolute path to a schema will vary between machines, e.g., between a local user and a CI machine. An additional source of volatility is the timestamp written to the file which will vary between every invocation even on the same machine.
With this change, the schema paths written to the schema manifest are relativized to the base project directory. The relative path to a schema is all that's required locate it and will always be consistent between machines. Additionally, the java-ordered-properties library is used to ensure the properties file is always written in a deterministic order and removes the unnecessary timestamp.