-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement own screenshot generator using node-webshot #6
Conversation
@artemgrygor working prototype! After giving some thoughts:
|
@outcoldman awesome, you're super fast :-) |
Implement own screenshot generator using node-webshot
@outcoldman Pulled these changes and I'm getting errors on all screenshots here. it says that it's blocked by the Cross-Origin Resource Sharing policy: No 'Access-Control-Allow-Origin' header. |
@jamiewilson we set @artemgrygor could you verify as well? @jamiewilson could you give it another try? possible that you tried when I was changing something on the server. |
@outcoldman Okay, cross origin working now. Two additional things:
|
@jamiewilson yeah |
@jamiewilson and about the 1 second - because we are limiting number of concurrent requests - everytime we wait 1 second before making screenshots - we delay screenshot generation for ALL other requests/users and also for this request as well. There are very limited number of websites which do that. I just don't think that we can afford it at current moment. |
@jamiewilson I will add |
That makes sense about the delay. I think you're right. We should probably lean towards producing them quickly for now and then if it makes sense later we can add the renderDelay if needed. Also, are you seeing any problems with rendering images for https addresses? |
@jamiewilson have not, it seems like because we are limited in the memory (512Mb for this droplet) we are getting a lot of |
@outcoldman @jamiewilson sorry for the delay was busy during the day. I can't check it on mac. Can't actually do npm install due to this error on Mac (nodejs/node-gyp#363) and their solution doesn't work. Can check only tomorrow on windows machine. |
@outcoldman @jamiewilson I confirm, it works on windows (just had to install ImageMagic exe with headers, probably need to do the same on mac). |
It is up and running now. I published new version to Chrome Store. @artemgrygor please keep your server running for a bit, soon we will be able to shut it down. |
No description provided.