Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #49, this PR replaces Travis with Github workflows
Workflows are based on what I regularly use in my own projects (eg, this or this)
Some notes:
pytest
instead ofnose
as .travis.yml and these requirements were inconsistenttests
workflow includes a commented job for style checks, same as travis didflake8
norblack
config (in setup.py or a pyproject.toml), so I left it the same way to be address in different PRtest.pypi.org
(by using a branch namedtestpypi-*
)tests
will be executed twice if a PR is opentests
workflow to not triggerif PR and source branch is testpypi*
but I felt like it wasn't worth (running tests is fast and it only happens twice for these special branches WITH open PR)I hope these helps!