-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glob method broken in python 3.11 #396
Labels
Comments
allburov
added
Bug
Help Wanted
We will be glad if somebody proposes a solution via PR
labels
Nov 21, 2022
I think the issue has something to do with this change: |
flichtenheld
added a commit
to flichtenheld/dohq_artifactory
that referenced
this issue
Jul 19, 2023
Python 3.11 replaced _accessor.scandir with _scandir. Override _scandir to still use our implementation. Should be a noop on older Python versions because they didn't have _scandir at all. Fixes: devopshq#396 Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Merged
allburov
pushed a commit
that referenced
this issue
Jul 24, 2023
* ArtifactoryPath: fix mkdir and rmdir with Python 3.11 pathlib in Python 3.11 implements mkdir and rmdir directly in terms of calling os.<func> without any accessor layer. So copy the implementations of those functions from Python 3.10 to get the previous behavior back. Fixes: #415 Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com> * test_artifactory_path: Add basic unit test for mkdir() Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com> * ArtifactoryPath: Fix glob() in Python 3.11 Python 3.11 replaced _accessor.scandir with _scandir. Override _scandir to still use our implementation. Should be a noop on older Python versions because they didn't have _scandir at all. Fixes: #396 Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com> --------- Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The glob method is broken in python 3.11. I've tested the same code in 3.10.8 and all is fine, but looks like things have changed in 3.11...
The text was updated successfully, but these errors were encountered: